[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [GT] Fix to I:Generic:ByName



Found additional areas where this indicator did not work. Fixed these.

The brittleness of this indicator comes from that the name of objects is
sometimes modified after it is generated by ArgsTrees::parse_args, which
makes code dependent on whether or not this modification had happened.

I have not been able to track down yet where this happens. However, it
can easily be observed that the name of the indicator used in
CacheValues::set is not the same at all times with respect to spaces as
the name generated by ArgsTree::parse_args.

As ByName depends on looking up the value of indicators by the name
obtained from parse_args it fails when these deviate. For all the tests
I have the attached fix resolves the problem.

Cheers, Th.

> -----Original Message-----
> From: Weigert, Thomas [mailto:weigert
AT
mst.edu]
> Sent: Sunday, March 09, 2008 12:57 AM
> To: devel
AT
geniustrader.org
> Subject: RE: [GT] Fix to I:Generic:ByName
> 
> Sorry, forgot to delete some redundant code... Th.
> 
> > -----Original Message-----
> > From: Weigert, Thomas
> > Sent: Saturday, March 08, 2008 7:47 PM
> > To: 'devel
AT
geniustrader.org'
> > Cc: Weigert, Thomas
> > Subject: Fix to I:Generic:ByName
> >
> > This indicator had a bug which made it somewhat difficult to predict
> when
> > it would work and when not. 

Attachment: ByName.pm
Description: ByName.pm