[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GT] Makefile for TeX conversion



On Wed, 12 Mar 2008, Robert A. Schmied wrote:

thanks for that work -- i tweaked it a bit to better suit my non-linux platform, hopefully making it a bit more adaptable to other plats as well. also hopefully added a bit of user-self protection by aborting before removing *.pdf if there isn't a latex found.

fast and low reply as I am on the way out the door for the day. ...

Why bother? -- It is only a 'co' away to replace and it really clutters the Makefile quite badly; if you wish, check for latex in the $PATH || die

A user who can get a VCS retrieval working in the first place can get the PDF content back trivially.

Beyond that we would be on a fool's errand to try to check for each and every needed binary here; that _may_ be a job for an autotools setup, which would then need to pick up a Makefile.in

The copyright related addition is simply wrong,
	"# Based on and for GeniusTrader (C) 2000-2002 Rapha?? Hertzog, Fabien Fulhaber"
as my offered makefile was based on nothing but new content of my own creation.

Also I would limit myself a line under 80 char, as I am of an older era; if one cannot see code or a linebreak indication, one has to make assumptions about what is out of sight or where a wrap is happening; assumptions lead to errors

The explicit redefine to 'gmake' is wrong as it destroys generality

Welcome to Darwin!
emac:~ herrold$ which gmake
no gmake in /bin /sbin /usr/bin /usr/sbin /usr/local/bin /usr/texbin
emac:~ herrold$

added a help target the content of which is mostly your instructions

That 'help' cruft is beyond fugly -- there are a multitude of things we _could_ check for, but simply dying early and loudly is enough; documentation belongs elsewhere. At a minimum, I would make it less unsightly with a 'here' document when there is nothing but a series of printf equivalents ;)

yelp if i did things badly, i don't have a (la)tex install to check it against.

I would not check in untested code; it is too easy to have a typo.

with my regards,

-- Russ herrold