Re: [GT] patches for GT/Systems.pm and GT/Systems/Generic.pm

["Robert A. Schmied" <ras AT acm.org>]

Weigert, Thomas wrote:
> If you pass only for arguments, the remaining two are undefined.
> Undefined is not the same as '' or 0, albeit often it works the same
> (and the latter gives less errors). It would be good to understand what
> should be assigned as key if no key is given.
>
> On this key and func parameters, I am not sure what they are used for...
> So I am nervous. In particular, if it removed warnings, that means that
> somewhere key is used in a calculation....
>
> Th.

<< snip >>

looking deeper gt/signals.pm has/does similar thing(s) but it's new
does have a input $key parameter and passes $key in the return
call to manage_object

i'm gonna bet there was a fix to GT::Signals::Module->new that
was applicable to GT::Systems::Module->new but it never made it


signals:
sub new {
   my ($type, $args, $key) = @_;
.
.
.
   return manage_object(\
AT
{"$class\::NAMES"}, $self, $class, $self->{'args'}, $key);

so systems should be changed to
sub new {
   my ($type, $args, $key) = @_;
.
.
.
   return manage_object(\
AT
{"$class\::NAMES"}, $self, $class, $self->{'args'}, $key);

from
sub new {
   my ($type, $args) = @_;
.
.
.
   return manage_object(\
AT
{"$class\::NAMES"}, $self, $class, $self->{'args'}, '');
or
   return manage_object(\
AT
{"$class\::NAMES"}, $self, $class, $self->{'args'});
depending on the current or pre-7nov07