[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [GT] patches for GT/Systems.pm and GT/Systems/Generic.pm

Weigert, Thomas wrote:

If you pass only for arguments, the remaining two are undefined.
Undefined is not the same as '' or 0, albeit often it works the same
(and the latter gives less errors). It would be good to understand what
should be assigned as key if no key is given.

On this key and func parameters, I am not sure what they are used for...
So I am nervous. In particular, if it removed warnings, that means that
somewhere key is used in a calculation....



thomas

can you tell me who/where/what even makes a call to GT::Systems::Module->new.

it happens in a graphic.pl, but i don't see any direct calls to
GT::Systems::Module->new (or ::Module->new) any place.

maybe i'm mis-using grep and need to resort to etags

ras



Th.



-----Original Message-----
From: Robert A. Schmied [mailto:ras

AT
acm.org]

Sent: Friday, March 14, 2008 11:25 PM
To: devel

AT
geniustrader.org

Subject: Re: [GT] patches for GT/Systems.pm and GT/Systems/Generic.pm

Weigert, Thomas wrote:


I don't understand the patch to Systems.pm. What reason do you have


to


think that '' is a good parameter for key? Nowhere else is '' being
passed as a parameter to $key. Please explain. Th.



i have no log for that change beyond the original email -- all i can


say


is i think (thought) it works(ed) better with a null value there than
having no parameter in that position.

i'm thinking the change reduced or eliminated extraneous uninitialized
or similar warnings?

there was nothing that looked like a key within the body of
GT::Systems::Module->new, and the orginial return had only
the initial four arguments.

i don't understand how passing four arguments to something expecting
six works, nor does it make sense that passing 5 is any better!


ras