Re: [GT] patches for GT/Systems.pm and GT/Systems/Generic.pm

["Robert A. Schmied" <ras AT acm.org>]

Weigert, Thomas wrote:
> ras,
>
> you are absolutely right and I apologize for the confusion. I did not
> actually mean to say what I said below, but what I really wanted to say
> was that I cannot see where $key (and for that matter, $func) where
> really used.
>
> I had hoped that since you specifically made that change you knew more
> about the usage of these mystery parameters.
>
> No matter what, the incorrect note had its intended effect: we are now
> studying these parameters.
>
> I will follow up on your diligent analysis...
>
> Thanks, Th.
>
>
> > -----Original Message-----
> > From: Robert A. Schmied [mailto:ras
AT
acm.org]
> > Sent: Monday, March 17, 2008 12:08 AM
> > To: devel
AT
geniustrader.org
> > Subject: Re: [GT] patches for GT/Systems.pm and GT/Systems/Generic.pm
> >
> > Weigert, Thomas wrote:
> >
> > > I don't understand the patch to Systems.pm. What reason do you have
>
> to
>
> > > think that '' is a good parameter for key? Nowhere else is '' being
> > > passed as a parameter to $key.
> >
> > i have to take exception to this last statement. there are plenty of
> > places $key is
> > being set to either "" or ''. here is a very truncated list:
> > GT/Signals/Trend/HilbertChannelBreakout.pm:    return

excellent

two things to emphasize -- the argument parameter, $func, is i believe completely
depreciated, no longer (if it was ever) supported in registry.pm, as implied
by the changes to the default new method in indicators.pm, as well as by the
actual argument list assignments in GT::Registry::manage_object. if there are
methods that attempt to access $func objects via registry methods something needs
to be revised.


the current repository version of registry.pm shows the following pod which
incorrectly lists the argument order for GT::Registry::manage_object

is:
=item C<< GT::Registry::manage_object($repository, \
AT
NAMES, $obj, $args, $key, $class) >>
should be:
=item C<< GT::Registry::manage_object($repository, \
AT
NAMES, $obj, $class, $args, $key) >>

please let the list know if you disagree!

aloha

ras