[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [GT] SVN Commit r589 - in trunk/GT: . DB



Some explanation of this commit....

Previously, DB::Text supported different formats for the market file: GT
format, US format, and EU format. The recent rewrite dropped this choice
and replaced it with the use of Date::Manip::UnixTime, with 2
consequences:

1. It is exrucitingly slow, compared to before.
2. EU format cannot be parsed.

I rewrite DB::Text to allow a choice between using Date::Manip,
Date::Calc, and GT format. This flexibility was possible before (well
excluding Date::Manip) the recent change, and should be restored. If you
do not change your options, the Date::Manip version is used, and you
will not notice a difference (well, there is some additional error
handling in case the date format in the file is incorrect).

Further, this change reuses GT::Prices::loadtext in both DB::Text and
DB::HTTP, making them both consistent and allowing easier maintenance.
Note that DB::HTTP had not been updated to use the same options as
DB::Text, when DB::Text was changed. Now they are both consistent again.

Please let me know if you find any problems with this change.

Cheers, Th.

> -----Original Message-----
> From: GeniusTrader SVN [mailto:raphael
AT
geniustrader.org]
> Sent: Saturday, March 22, 2008 11:40 PM
> To: devel
AT
geniustrader.org
> Subject: [GT] SVN Commit r589 - in trunk/GT: . DB
> 
> Author: thomas
> Date: 2008-03-23 05:39:32 +0100 (Sun, 23 Mar 2008)
> New Revision: 589
> 
> Modified:
>    trunk/GT/DB/HTTP.pm
>    trunk/GT/DB/Text.pm
>    trunk/GT/Prices.pm
> Log:
> Restore faster date formats. Reuse between DB::Text and DB::HTTP.
>