Re: [GT] SVN Commit r637 - branches/exp/GT

["Robert A. Schmied" <ras AT acm.org>]

GeniusTrader SVN wrote:
> Author: thomas
> Date: 2008-06-14 07:26:24 +0200 (Sat, 14 Jun 2008)
> New Revision: 637
>
> Modified:
>    branches/exp/GT/Tools.pm
> Log:
> Handle recursive object aliases. Fix incorrect error message in check_dates.
>
> Modified: branches/exp/GT/Tools.pm
> ===================================================================
> --- branches/exp/GT/Tools.pm	2008-06-14 05:25:10 UTC (rev 636)
> +++ branches/exp/GT/Tools.pm	2008-06-14 05:26:24 UTC (rev 637)
> @@ -243,7 +243,8 @@
>  
>      # Lookup the alias
>      my $def = GT::Conf::get("Aliases\::$alias");
> -    
> +    warn "Alias $alias not found.\n";

without any research beyond looking at the file itself (crap it's not
branches/exp/GT/Tools.pm, it's really GT/Tools.p so ignore this if the
branches/exp version has materially different control flow);

it appears on the face that this warning message will always be generated
whether $alias is found or not. looks to me like some sort of conditional
expression needs to be used to gate the warning.


ras

> +
>      my $n = 1;
>      foreach my $arg (GT::ArgsTree::args_to_ascii(@param))
>      {


<snip>