[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [GT] Minor performance patch for genericdbi.pm



On Thu, 17 Jul 2008, João Costa wrote:
> This database module is including other modules which it doesn't need.
>  This should be a seamless patch.

You need it:
> -use GT::DateTime;
[...]
> -    $timeframe = $DAY unless ($timeframe);
> +    $timeframe = $GT::DateTime::DAY unless ($timeframe);

You're using GT::DateTime so why do you say that you don't need it?

If you need it but you don't want the associated imported
variables/functions, then you have to say:
use GT::DateTime qw();

You explicitely import nothing but you have to load the module otherwise
you have no guaranty that GT::DateTime exists at all...

Cheers,
-- 
Raphaël Hertzog -+- http://www.ouaza.com

Freexian : des développeurs Debian au service des entreprises
http://www.freexian.com