[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[GT] Re: Proposed patch for Indicators::new()
Nick Fantes Huege wrote:
The constructor function 'new' for GT::Indicators attempts to
reference the variable $args in a slightly illegal way. To avoid an
interpreter error the author has added 'no strict "refs"' to the code.
To improve compatibility and to keep "strict" turned on at all times,
I have modified the sub as follows:
<< big snip >>
nick
i will evaluate your changes, however, you will find similar code in most
of the other 'new()' methods for all data objects implemented by gt.
GT::Analyzers
GT::CloseStrategy
GT::Indicators
GT::OrderFactory
GT::Signals
GT::Systems
GT::TradeFilters
GT::DB::CSV
maybe even GT::Indicators::Generic::ByName
maybe even GT::Indicators::Generic::Container
so if we really want to make this change (i'm not against it, i have gotten
more than one headache staring at those 'new()' method code blocks than i
care to remember), but to do the right thing we really should fix all of
them at the same time.
how much evaluation testing have you conducted (and how) to show this change
is equivalent?
as far as versions go -- i will try to always refer to the gt trunk version
not the cpan or exp branches.
ras